Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate ML - File Datavisualizer (Part 2) #25642

Merged
merged 7 commits into from
Dec 12, 2018
Merged

[i18n] Translate ML - File Datavisualizer (Part 2) #25642

merged 7 commits into from
Dec 12, 2018

Conversation

tibmt
Copy link
Contributor

@tibmt tibmt commented Nov 14, 2018 •
edited
Loading

translate file_datavisualizer folder of Machine Learning (Part 2)

#25454

Guidline
Readme

@tibmt tibmt self-assigned this Nov 14, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pavel06081991 pavel06081991 requested review from pavel06081991 and removed request for pavel06081991 and maryia-lapata December 7, 2018 08:03
pavel06081991
pavel06081991 approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata self-requested a review December 12, 2018 07:05
peteharverson
peteharverson approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with pseudo locale and all LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991 pavel06081991 merged commit af8147d into elastic:master Dec 12, 2018
@pavel06081991 pavel06081991 mentioned this pull request Dec 12, 2018
Merged
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Dec 12, 2018
@tibmt @pavel06081991
[i18n] Translate ML - File Datavisualizer (Part 2) (elastic#25642)
8f9c036 
translate file_datavisualizer folder of Machine Learning (Part 2)
@peteharverson peteharverson mentioned this pull request Dec 12, 2018
Merged
pavel06081991 added a commit that referenced this pull request Dec 13, 2018
@pavel06081991
[6.x] [i18n] Translate ML - File Datavisualizer (Part 2) (#25642) (#2…
8596da5 
…7040)

* [i18n] Translate ML - File Datavisualizer (Part 2) (#25642)

translate file_datavisualizer folder of Machine Learning (Part 2)

[ML] Remove duplicate import in file_datavisualizer_directive (#27044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@tibmt tibmt

Labels
backported Feature:Anomaly Detection ML anomaly detection :ml Project:i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tibmt @elasticmachine @peteharverson @pavel06081991 @maryia-lapata